PMD Results
The following document contains the results of PMD 6.4.0.
Files
spring-boot-jackson2-report-aggregate - top/infra/jackson2/CommonsLangDeserializers.java
| Violation | Priority | Line |
|---|---|---|
| Avoid unused imports such as 'com.fasterxml.jackson.databind.DeserializationContext' | 4 | 5 |
| Comment is too large: Line too long | 3 | 19 |
| It is a good practice to call super() in a constructor | 3 | 27–29 |
| The method 'findBeanDeserializer(JavaType, DeserializationConfig, BeanDescription)' has a NCSS line count of 18. | 3 | 32–58 |
| Local variable 'valueDeser' could be declared final | 3 | 53 |
| Local variable 'keyDes' could be declared final | 3 | 54 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 55 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/CommonsLangJackson2MapperCustomizerFactory.java
| Violation | Priority | Line |
|---|---|---|
| To avoid mistakes add a comment at the beginning of the CLASS_MUTABLE_PAIR field if you want a default access modifier | 3 | 9 |
| To avoid mistakes add a comment at the beginning of the CLASS_PAIR field if you want a default access modifier | 3 | 10 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/CommonsLangSerializers.java
| Violation | Priority | Line |
|---|---|---|
| Comment is too large: Line too long | 3 | 21 |
| Local variable 'lType' could be declared final | 3 | 33 |
| Local variable 'rType' could be declared final | 3 | 34 |
| Local variable 'staticTyping' could be declared final | 3 | 35 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 38 |
| Comment is too large: Line too long | 3 | 44 |
| The method 'createTypeSerializer(SerializationConfig, JavaType)' has a NCSS line count of 15. | 3 | 46–69 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 48 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 64 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/deser/PairDeserializer.java
| Violation | Priority | Line |
|---|---|---|
| Avoid using Literals in Conditional Statements | 3 | 69 |
| Useless parentheses. | 4 | 116 |
| Useless parentheses. | 4 | 116 |
| Useless parentheses. | 4 | 117 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 118 |
| The method 'createContextual(DeserializationContext, BeanProperty)' has a NCSS line count of 22. | 3 | 139–169 |
| Local variable 'keyType' could be declared final | 3 | 145 |
| Local variable 'valueType' could be declared final | 3 | 158 |
| The method 'deserialize(JsonParser, DeserializationContext)' has an NPath complexity of 288 | 3 | 179–226 |
| The method 'deserialize(JsonParser, DeserializationContext)' has a cyclomatic complexity of 11. | 3 | 179–226 |
| The method 'deserialize(JsonParser, DeserializationContext)' has a NCSS line count of 32. | 3 | 179–226 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 185 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 193 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 195 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 223 |
| The method 'deserializeField(JsonParser, DeserializationContext)' has a NCSS line count of 15. | 3 | 228–246 |
| The method 'deserializeField(JsonParser, DeserializationContext, String, JsonDeserializer, TypeDeserializer)' has a NCSS line count of 13. | 3 | 248–270 |
| Local variable 't' could be declared final | 3 | 256 |
| Avoid reassigning parameters such as 't' | 2 | 309 |
| The method 'wrapAndThrow(Throwable, Object, String)' has a cyclomatic complexity of 10. | 3 | 309–327 |
| Avoid reassigning parameters such as 'key' | 2 | 309 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/ser/PairSerializer.java
| Violation | Priority | Line |
|---|---|---|
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_ks' is not final. | 1 | 49 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_vs' is not final. | 1 | 53 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_dks' is not final. | 1 | 58 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_dvs' is not final. | 1 | 63 |
| The constructor 'PairSerializer(PairSerializer, BeanProperty, TypeSerializer, JsonSerializer, JsonSerializer)' has a NCSS line count of 13. | 3 | 84–103 |
| Avoid unused constructor parameters such as 'property'. | 3 | 86 |
| Avoid unused constructor parameters such as 'vts'. | 3 | 87 |
| The method 'createContextual(SerializerProvider, BeanProperty)' has an NPath complexity of 768 | 3 | 106–156 |
| The method 'createContextual(SerializerProvider, BeanProperty)' has a NCSS line count of 30. | 3 | 106–156 |
| The method 'createContextual(SerializerProvider, BeanProperty)' has a cyclomatic complexity of 15. | 3 | 106–156 |
| Local variable 'mser' could be declared final | 3 | 153 |
| Consider simply returning the value vs storing it in local variable 'mser' | 3 | 155 |
| Parameter 'ks' is not assigned and could be declared final | 3 | 158 |
| Parameter 'vs' is not assigned and could be declared final | 3 | 158 |
| Parameter 'property' is not assigned and could be declared final | 3 | 158 |
| The method 'serializeDynamic(Pair, JsonGenerator, SerializerProvider)' has a cyclomatic complexity of 11. | 3 | 190–258 |
| The method 'serializeDynamic(Pair, JsonGenerator, SerializerProvider)' has a NCSS line count of 45. | 3 | 190–258 |
| Local variable 'valueElem' could be declared final | 3 | 201 |
| Local variable 'keyElem' could be declared final | 3 | 202 |
| Local variable 'cc' could be declared final | 3 | 208 |
| Do not add empty strings | 3 | 226 |
| Local variable 'keyDesc' could be declared final | 3 | 226 |
| Local variable 'cc' could be declared final | 3 | 236 |
| Do not add empty strings | 3 | 254 |
| Local variable 'keyDesc' could be declared final | 3 | 254 |
| The method method name '_findAndAddDynamicKeySerializer' doesn't match '[a-z][a-zA-Z0-9]+' | 1 | 261–265 |
| The method method name '_findAndAddDynamicKeySerializer' doesn't match '[a-z][a-zA-Z0-9]+' | 1 | 273–277 |
| The method method name '_findAndAddDynamicValueSerializer' doesn't match '[a-z][a-zA-Z0-9]+' | 1 | 285–289 |
| The method method name '_findAndAddDynamicValueSerializer' doesn't match '[a-z][a-zA-Z0-9]+' | 1 | 297–301 |
spring-boot-jackson2-report-aggregate - top/infra/common/ClassUtils.java
| Violation | Priority | Line |
|---|---|---|
| Avoid reassigning parameters such as 'classLoader' | 2 | 52 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 58 |
| A catch statement should never catch throwable since it includes errors. | 3 | 59 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 66 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 80 |
| Local variable 'classLoader' could be declared final | 3 | 87 |
spring-boot-jackson2-report-aggregate - top/infra/common/EnumUtils.java
| Violation | Priority | Line |
|---|---|---|
| This abstract class does not have any abstract methods | 3 | 10–68 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 40 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 52 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 63 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/DefaultJackson2Customizer.java
| Violation | Priority | Line |
|---|---|---|
| The method 'customize(Jackson2Properties, ObjectMapper)' has a NCSS line count of 17. | 3 | 32–77 |
| In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 66 |
| The method 'customize(Jackson2Properties, Jackson2ObjectMapperBuilder)' has a NCSS line count of 18. | 3 | 81–125 |
| The method 'configureDateFormat(Jackson2Properties, ObjectMapper)' has a NCSS line count of 12. | 3 | 136–159 |
| Local variable 'dateFormat' could be declared final | 3 | 139 |
| Local variable 'dateFormatClass' could be declared final | 3 | 142 |
| Local variable 'simpleDateFormat' could be declared final | 3 | 145–146 |
| When instantiating a SimpleDateFormat object, specify a Locale | 3 | 145–146 |
| To avoid mistakes add a comment at the beginning of the feature method if you want a default access modifier | 3 | 169–171 |
| To avoid mistakes add a comment at the beginning of the feature method if you want a default access modifier | 3 | 173–175 |
| To avoid mistakes add a comment at the beginning of the feature method if you want a default access modifier | 3 | 177–179 |
| To avoid mistakes add a comment at the beginning of the feature method if you want a default access modifier | 3 | 181–183 |
| To avoid mistakes add a comment at the beginning of the feature method if you want a default access modifier | 3 | 185–187 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/Jackson2BuilderCustomizer.java
| Violation | Priority | Line |
|---|---|---|
| In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 44 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/Jackson2MapperCustomizerFactory.java
| Violation | Priority | Line |
|---|---|---|
| The method 'newInstanceIfPresent(String, Collection)' has a NCSS line count of 13. | 3 | 14–34 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/Jackson2Properties.java
| Violation | Priority | Line |
|---|---|---|
| Avoid using redundant field initializer for 'timeZone' | 3 | 86 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/Jackson2Utils.java
| Violation | Priority | Line |
|---|---|---|
| Variables should start with a lowercase character, 'JACKSON2_PRESENT' starts with uppercase character. | 1 | 28 |
| Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'JACKSON2_PRESENT' is not final. | 1 | 28 |
| The field name indicates a constant but its modifiers do not | 3 | 28 |
| To avoid mistakes add a comment at the beginning of the jackson2MapperCustomizers method if you want a default access modifier | 3 | 91–99 |
| To avoid mistakes add a comment at the beginning of the jackson2MapperCustomizerFactories method if you want a default access modifier | 3 | 101–110 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/HalJackson2Customizer.java
| Violation | Priority | Line |
|---|---|---|
| A method should have only one exit point, and that should be the last statement in the method | 3 | 48 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 64 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/HalJackson2MapperCustomizerFactory.java
| Violation | Priority | Line |
|---|---|---|
| To avoid mistakes add a comment at the beginning of the CLASS_JACKSON2_HAL_MODULE field if you want a default access modifier | 3 | 9 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/JaxbAnnotationJackson2Customizer.java
| Violation | Priority | Line |
|---|---|---|
| The method 'jaxbAnnotationModule()' has a NCSS line count of 12. | 3 | 63–81 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 75 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/JaxbAnnotationJackson2MapperCustomizerFactory.java
| Violation | Priority | Line |
|---|---|---|
| To avoid mistakes add a comment at the beginning of the CLASS_JAXB_ANNOTATION_INTROSPECTOR field if you want a default access modifier | 3 | 9 |
| To avoid mistakes add a comment at the beginning of the CLASS_JAXB_ANNOTATION_MODULE field if you want a default access modifier | 3 | 10 |
| To avoid mistakes add a comment at the beginning of the CLASS_JAXB_ANNOTATION_MODULE_PRIORITY field if you want a default access modifier | 3 | 11 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/DefaultTimeZone.java
| Violation | Priority | Line |
|---|---|---|
| This abstract class does not have any abstract methods | 3 | 16–52 |
| Variables that are final and static should be all capitals, 'yyyyMMdd_HHmmss' is not all capitals. | 1 | 34 |
| Unnecessary use of fully qualified name 'DateTimeFormat.forPattern' due to existing static import 'org.joda.time.format.DateTimeFormat.forPattern' | 4 | 39 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/JodaTimeJackson2Customizer.java
| Violation | Priority | Line |
|---|---|---|
| Local variable 'module' could be declared final | 3 | 40 |
| Local variable 'jacksonJodaFormat' could be declared final | 3 | 41 |
| To avoid mistakes add a comment at the beginning of the getJacksonJodaDateFormat method if you want a default access modifier | 3 | 51–68 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 53 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 57 |
spring-boot-jackson2-report-aggregate - top/infra/jackson2/JodaTimeJackson2MapperCustomizerFactory.java
| Violation | Priority | Line |
|---|---|---|
| To avoid mistakes add a comment at the beginning of the CLASS_DATE_TIME field if you want a default access modifier | 3 | 9 |
| To avoid mistakes add a comment at the beginning of the CLASS_DATE_TIME_SERIALIZER field if you want a default access modifier | 3 | 10 |
| To avoid mistakes add a comment at the beginning of the CLASS_JACKSON_JODA_DATE_FORMAT field if you want a default access modifier | 3 | 11 |
spring-boot-jackson2-tests - top/infra/test/classloader/ClassLoaderChangerRunner.java
| Violation | Priority | Line |
|---|---|---|
| It is a good practice to call super() in a constructor | 3 | 18–26 |
spring-boot-jackson2-tests - top/infra/test/classloader/exclude/ExcludeClassJunitRunner.java
| Violation | Priority | Line |
|---|---|---|
| This statement should have braces | 3 | 57 |
spring-boot-jackson2-tests - top/infra/test/classloader/exclude/ExcludeClassesClassLoader.java
| Violation | Priority | Line |
|---|---|---|
| Overridable method 'setExcludes' called during object construction | 1 | 27 |
| The method 'loadClass(String)' has a cyclomatic complexity of 11. | 3 | 32–60 |
| Use block level rather than method level synchronization | 3 | 32–60 |
| The method 'loadClass(String)' has a NCSS line count of 13. | 3 | 32–60 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 53 |
spring-boot-jackson2-tests - top/infra/test/classloader/multi/LibrarySetClassLoader.java
| Violation | Priority | Line |
|---|---|---|
| Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 14 |
| In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 15 |
| Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 19 |
| Avoid throwing raw exception types. | 1 | 27 |
| A method should have only one exit point, and that should be the last statement in the method | 3 | 35 |